gh-155869: Fix data loss in dbm.dumb.reorganize() - #155872
Merged
Merged
Conversation
lkk7
requested review from
corona10,
erlend-aasland and
serhiy-storchaka
as code owners
August 15, 2026 20:11
serhiy-storchaka
enabled auto-merge (squash)
August 15, 2026 20:29
|
Thanks @lkk7 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-155874 is a backport of this pull request to the 3.15 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbm.dumb.reorganize()can move values without persisting their new offsets. Persist the changed index and add a regression test.dbm.dumb.reorganize()can cause data loss after reopening #155869