Skip to content

gh-155782: avoid a crash in ssl.SSLObject.group for session-less objects #155829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
picnixz wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −1
Open

gh-155782: avoid a crash in ssl.SSLObject.group for session-less objects #155829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
285ae34
gh-155782: avoid a crash in `ssl.SSLObject.group` for session-less ob…
picnixz Aug 15, 2026
f6d577e
Update Misc/NEWS.d/next/Library/2026-08-15-11-30-42.gh-issue-155782.J…
picnixz Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Lib/test/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,6 +1097,15 @@ def test_set_server_sigalgs(self):
if CAN_IGNORE_UNKNOWN_OPENSSL_SIGALGS:
self.assertIsNone(ctx.set_server_sigalgs('rsa_pss_rsae_sha256:?foo'))

@unittest.skipUnless(CAN_GET_SELECTED_OPENSSL_GROUP,
"SSL library doesn't support getting selected group")
def test_no_session_group_does_not_crash(self):
# Ensure that .group() does not crash because of OpenSSL itself.
# See https://github.com/python/cpython/issues/155782.
ctx = ssl.create_default_context()
obj = ctx.wrap_bio(ssl.MemoryBIO(), ssl.MemoryBIO())
self.assertIsNone(obj.group())

def test_options(self):
# Test default SSLContext options
ctx = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-08-15-11-30-42.gh-issue-155782.JUmDP4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
:mod:`ssl`: prevent a crash in :meth:`~ssl.SSLSocket.group`
for session-less objects on OpenSSL 3.2 and later. Patch by Bénédikt Tran.
4 changes: 3 additions & 1 deletion Modules/_ssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2224,7 +2224,9 @@ _ssl__SSLSocket_group_impl(PySSLSocket *self)
#if OPENSSL_VERSION_NUMBER >= 0x30200000L
const char *group_name;

if (self->ssl == NULL) {
// OpenSSL issue: SSL_get0_group_name(...) crashes if no session exists.
// See https://github.com/openssl/openssl/issues/32379.
if (self->ssl == NULL || SSL_get_session(self->ssl) == NULL) {
Py_RETURN_NONE;
}
group_name = SSL_get0_group_name(self->ssl);
Expand Down
Loading