gh-155799: Fix incorrect anchor links - #155800
Open
rosstitmarsh wants to merge 1 commit into
Open
Conversation
rosstitmarsh
requested review from
AA-Turner,
ZeroIntensity and
willingc
as code owners
August 14, 2026 14:06
Documentation build overview
|
…and index directive
rosstitmarsh
force-pushed
the
fix-issue-155799
branch
from
August 14, 2026 14:52
6ef0fec to
90f8686
Compare
aisk
approved these changes
Aug 14, 2026
|
|
||
| .. _memoryview-objects: | ||
|
|
||
| .. index:: |
Member
There was a problem hiding this comment.
Quoting the Sphinx documentation:
Since index directives generate cross-reference targets at their location in the source, it makes sense to put them before the thing they refer to – e.g. a heading
As such I'm not sure about this change, the missing anchor should be fixed upstream instead. Possibly something to do with the reference label messing with the anchor? I suggest you open an issue in sphinx-doc/sphinx repository.
Author
There was a problem hiding this comment.
Every other adjacent file I looked in has it heading then index so I thought that was the convention here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed by swapping the heading and index directive.
This has resolved
#private-name-manglingand#memoryview-objects.However I cannot see why
#identifiers-namesis still wrong. It is identical to the "Literals" heading which is correct.