gh-155742: Get PyBytes_AS_STRING() as const char* - #155751
Open
vstinner wants to merge 2 commits into
Open
Conversation
Use "const char*" type instead of "char*" to store PyBytes_AS_STRING(). Treat immutable bytes as immutable.
picnixz
reviewed
Aug 13, 2026
| { | ||
| char *buf = NULL, *buf2 = NULL, *name_chars; | ||
| char *buf = NULL, *buf2 = NULL; | ||
| char *name_chars; |
Member
There was a problem hiding this comment.
I'm not sure about this change (?) are you smissing a const here?
Member
Author
There was a problem hiding this comment.
Oh. At some stage of my patch, it was const char *, but then I had to revert to char *. At the end, this change is not needed, I just reverted it (same in the pwd module).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use "const char*" type instead of "char*" to store PyBytes_AS_STRING(). Treat immutable bytes as immutable.