gh-155702: Fix sqlite3.Blob slice assignment with a step - #155703
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-155702: Fix sqlite3.Blob slice assignment with a step#155703serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
It patched the bytes object read from the blob, which for a single byte is an immortal singleton, so that the value of that byte was changed in the whole process. Read into a plain buffer instead. The raw read is factored out of read_multiple() into inner_read().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ass_subscript_slice()patched the bytes object read from the blob and wrote it back.For a single byte that object is an immortal singleton, so the value of that byte was changed in the whole process.
It now reads into a plain buffer.
The raw read is factored out of
read_multiple()intoinner_read(), like the existinginner_write().The negative step case (gh-150449, GH-150450) still raises the same
ValueErroras before.