gh-149679: Document that cadata does not accept CRLs - #155701
Open
mangrisano wants to merge 1 commit into
Open
Conversation
Documentation build overview
|
mangrisano
force-pushed
the
gh-149679-document-cadata-no-crl
branch
from
August 13, 2026 13:38
da80d90 to
9ba3edf
Compare
mangrisano
force-pushed
the
gh-149679-document-cadata-no-crl
branch
from
August 13, 2026 15:32
9ba3edf to
099c8e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents that
SSLContext.load_verify_locations()accepts CRLs only through cafile or capath, not through cadata.cafile/capathare passed to OpenSSL'sSSL_CTX_load_verify_locations, which loads CRLs in addition to certificates.cadata, on the other hand, is handled by_add_ca_certsinModules/_ssl.c, which reads X.509 certificates only (d2i_X509_bio/PEM_read_bio_X509+X509_STORE_add_cert). Supplying a CRL throughcadatatherefore raisesSSLError: "cadata does not contain a certificate"rather than loading it.The docs previously stated that the method "can also load certification revocation lists (CRLs)" without noting this restriction.