gh-141174: Test type_repr() of Template with invalid syntax in Interpolation - #155661
Merged
Conversation
JelleZijlstra
enabled auto-merge (squash)
August 13, 2026 14:18
|
Thanks @dr-carlos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-155711 is a backport of this pull request to the 3.15 branch. |
|
GH-155712 is a backport of this pull request to the 3.14 branch. |
JelleZijlstra
pushed a commit
that referenced
this pull request
Aug 13, 2026
…x in `Interpolation` (GH-155661) (#155712) gh-141174: Test `type_repr()` of `Template` with invalid syntax in `Interpolation` (GH-155661) Test `type_repr()` of `Template` with invalid syntax in `Interpolation` (cherry picked from commit 5cc9e46) Co-authored-by: dr-carlos <77367421+dr-carlos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is no test in
test_annotationlib.pyof the following lines:cpython/Lib/annotationlib.py
Lines 643 to 644 in 025e7d2
These ensure that a reasonable value is returned when stringifying a
Templateannotation containing invalid syntax.This could be tested for both
get_annotations(format=Format.STRING)andtype_repr(). But, it's impossible from a syntactic t-string and only possbile through artificialTemplateconstruction, which is only currently tested within thetype_repr()tests. So I've only added a test there. Happy to add them in other places if that's required.