gh-89735: Document requirements for the *headers* argument - #155640
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-89735: Document requirements for the *headers* argument#155640serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Both handlers look up the header name in lowercase, and the basic one needs get_all(), so a plain dict does not work. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractBasicAuthHandler.http_error_auth_reqed()looks upheaders.get_all('www-authenticate')andAbstractDigestAuthHandler.http_error_auth_reqed()looks upheaders.get('www-authenticate'), both with a lowercase name.A plain
dicttherefore does not work: it has noget_all(), and its lookup is case-sensitive, so the header is silently not found.🤖 Generated with Claude Code