gh-57336: Deprecate setting read-only attributes in xml.dom.minidom - #155627
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-57336: Deprecate setting read-only attributes in xml.dom.minidom#155627serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Documentation build overview
|
…idom In the DOM model most node attributes are read-only, but in minidom only localName and length raised NoModificationAllowedErr. Setting the other ones silently left the node inconsistent with the document: for example, setting Attr.name renamed the attribute node, but the owner element still kept it under the old name. Setting them now emits a DeprecationWarning. They are also documented as read-only.
serhiy-storchaka
force-pushed
the
gh-57336-deprecate-readonly-setters
branch
from
August 12, 2026 15:04
cd1c027 to
94bd452
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the DOM model most node attributes are read-only, but in minidom only
localNameandlengthraisedNoModificationAllowedErr. Setting the other ones silently left the node inconsistent with the document: for example, settingAttr.namerenamed the attribute node, but the owner element still kept it under the old name.Setting them now emits a
DeprecationWarning. They are also documented as read-only.