Skip to content

gh-61366: Write session cookies in the curl and Wget format - #155602

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:gh-61366-write-curl-format
Aug 12, 2026
Merged

gh-61366: Write session cookies in the curl and Wget format#155602
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:gh-61366-write-curl-format

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 12, 2026

Copy link
Copy Markdown
Member

Session cookies are now saved with 0 in the expiration time field, as curl and Wget do. Previously this field was left empty, and such lines are ignored by curl and Wget, so all session cookies were lost.

This is based on #11792, which adds reading such files, and should be merged after it. Unlike it, this change is not backported, because files written with 0 are not read by unpatched Python.

@bedevere-app bedevere-app Bot mentioned this pull request Aug 12, 2026
Closed
@serhiy-storchaka
Write 0 in the expiration time field for session cookies
68b2df8 
curl and Wget ignore the line if this field is empty.
@serhiy-storchaka
serhiy-storchaka force-pushed the gh-61366-write-curl-format branch from fa1e89f to 68b2df8 Compare August 12, 2026 08:42
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) August 12, 2026 08:53
@serhiy-storchaka
serhiy-storchaka merged commit a4a5a06 into python:main Aug 12, 2026
51 checks passed
@bedevere-bot

bedevere-bot commented Aug 12, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Alpine Linux 3.x (tierless) has failed when building commit a4a5a06.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/301/builds/15878) and take a look at the build logs.
  4. Check if the failure is related to this commit (a4a5a06) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/301/builds/15878

Summary of the results of the build (if available):

Click to see traceback logs 
Note: switching to 'a4a5a06767e03c09d169480f82da944fae663db1'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at a4a5a06767e0 gh-61366: Write session cookies in the curl and Wget format (GH-155602)
Switched to and reset branch 'main'

configure: WARNING: x86_64-pc-linux-musl/gcc is not supported
configure: WARNING:

Platform "x86_64-pc-linux-musl" with compiler "gcc" is not supported by the
CPython core team, see https://peps.python.org/pep-0011/ for more information.


ar: unable to copy file 'libpython3.16d.a'; reason: No space left on device
make: *** [Makefile:1164: libpython3.16d.a] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @bedevere-bot