gh-88580: Run profile scripts in __main__ namespace - #155600
Draft
NithishKumar04 wants to merge 1 commit into
Draft
gh-88580: Run profile scripts in __main__ namespace#155600NithishKumar04 wants to merge 1 commit into
NithishKumar04 wants to merge 1 commit into
Conversation
The profile CLI executed script globals separately from the module stored in sys.modules["__main__"]. Deferred dataclass annotations therefore resolved against the profiler module and failed to recognize InitVar fields. Create a real __main__ module and execute the profiled script in its namespace, matching direct script execution and cProfile.
|
The following commit authors need to sign the Contributor License Agreement: |
Member
|
You must sign the CLA before we can review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88580.
python -m profileexecuted the target script in a standalone globalsdictionary while
sys.modules["__main__"]still referred to the profiler.Dataclasses resolving deferred
InitVarannotations through the class moduletherefore inspected the wrong namespace and generated an invalid constructor.
Create a real
__main__module and execute the profiled script in itsnamespace, matching direct script execution and
cProfile. Add regressioncoverage for the reported deferred-annotation case and a NEWS entry.
Tests:
make patchcheck./python -m test -v test_profile test_profiling.test_tracing_profiler./python -m test -v test_dataclasses test_pstats./python -m test -j8(one unrelated macOStest_utime_fdtimestamp failure;it passed on immediate isolated rerun)