Skip to content

gh-100710: Add nodeValue default to xml.dom.minidom.Node base class #155586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SomSamantray wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −0
Open

gh-100710: Add nodeValue default to xml.dom.minidom.Node base class #155586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d85200
gh-100710: Add nodeValue default to xml.dom.minidom.Node base class
SomSamantray Aug 11, 2026
b13fc5e
Merge branch 'main' into gh-100710-minidom-nodevalue
SomSamantray Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Lib/test/test_minidom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,15 @@ def testDocumentAsyncAttr(self):
self.assertFalse(doc.async_)
self.assertFalse(Document.async_)

def testNodeValueDefaultOnBaseNode(self):
# gh-100710: nodeValue must be declared on the base Node class
# (not just on its subclasses) so that generic Node-typed code
# and static type checkers see the attribute.
self.assertIsNone(Node.nodeValue)
node = Node()
self.assertTrue(hasattr(node, 'nodeValue'))
self.assertIsNone(node.nodeValue)

def testParseFromBinaryFile(self):
with open(tstfile, 'rb') as file:
dom = parse(file)
Expand Down
1 change: 1 addition & 0 deletions Lib/xml/dom/minidom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ class Node(xml.dom.Node):
ownerDocument = None
nextSibling = None
previousSibling = None
nodeValue = None

prefix = EMPTY_PREFIX # non-null only for NS elements and attributes

Expand Down
5 changes: 5 additions & 0 deletions Misc/NEWS.d/next/Library/2026-08-11-18-30-00.gh-issue-100710.6V5Prz.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Add a class-level ``nodeValue`` default (``None``) to the base
:class:`!Node` class in :mod:`xml.dom.minidom`, matching the DOM
interface it implements. Every concrete subclass already sets
``nodeValue`` at runtime, so this only affects code and static type
checkers that reference a bare ``Node``-typed value.
Loading