Skip to content

gh-155561: Build most _testlimitedcapi files with Py_TARGET_ABI3T - #155570

Open
vstinner wants to merge 2 commits into
python:mainfrom
vstinner:test_target_abi3t
Open

gh-155561: Build most _testlimitedcapi files with Py_TARGET_ABI3T#155570
vstinner wants to merge 2 commits into
python:mainfrom
vstinner:test_target_abi3t

Conversation

@vstinner

@vstinner vstinner commented Aug 11, 2026

Copy link
Copy Markdown
Member

The following files are not build with Py_TARGET_ABI3T:

  • Modules/_testlimitedcapi.c
  • Modules/_testlimitedcapi/heaptype_relative.c
  • Modules/_testlimitedcapi/vectorcall_limited.c

The following files are not build with Py_TARGET_ABI3T:

* Modules/_testlimitedcapi.c
* Modules/_testlimitedcapi/heaptype_relative.c
* Modules/_testlimitedcapi/vectorcall_limited.c
@vstinner

Copy link
Copy Markdown
Member Author

@encukou @ngoldbaum: Here is a first uncontroversial change to build most of the _testlimitedcapi extension module with Py_TARGET_ABI3T on Free Threading. Would you mind to review it?

If this change lands, I plan to write one or multiple PRs to use Py_TARGET_ABI3T in the 3 remaining files, which will require more work.

The 3.15 branch is frozen for release candidate releases. IMO this change should be backported to 3.15, but it can wait for Python 3.15.1. So I will do that once the 3.15 branch will be unblocked.

@ngoldbaum ngoldbaum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks except maybe the comment in parts.h.

I can confirm that everything works as advertised here and the skipped modules besides parts.h all have nontrivial fixes.

Comment thread Modules/_testlimitedcapi/parts.h
Comment thread Modules/_testlimitedcapi.c Outdated
Comment thread Modules/_testlimitedcapi/version.c Outdated
@vstinner

Copy link
Copy Markdown
Member Author

@ngoldbaum: I tried to address your review. Please review the updated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants