Skip to content

[3.15] gh-154874: Fix the sign of curses.termattrs() (GH-154875) #155548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sankalpsthakur wants to merge 1 commit into
base: 3.15
Choose a base branch
from
Open

[3.15] gh-154874: Fix the sign of curses.termattrs() (GH-154875) #155548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Lib/test/test_curses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,6 +1023,20 @@ def test_env_queries(self):
self.assertIsInstance(c, bytes)
self.assertEqual(len(c), 1)

def test_termattrs_is_not_negative(self):
# A_ITALIC is the topmost bit of a 32-bit attribute mask, so termattrs()
# only tells a signed result from an unsigned one on a terminal that
# advertises it. 3.15 lacks the newterm()/pty harness used on main, so
# exercise the current screen: skip when the top bit is not advertised.
attrs = curses.termattrs()
italic = getattr(curses, 'A_ITALIC', 0)
if not italic or not attrs & italic:
self.skipTest('the terminal advertises no attribute in the top bit')
self.assertGreaterEqual(attrs, 0)
# termattrs() exists to be passed back to the attribute functions,
# which reject a negative mask.
self.stdscr.attrset(attrs)

def test_output_options(self):
stdscr = self.stdscr

Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-07-29-11-58-17.gh-issue-154874.NAPdBp.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix :func:`curses.termattrs` returning a negative value on a terminal that
supports :const:`curses.A_ITALIC`, which left its result unusable as an
attribute mask.
6 changes: 5 additions & 1 deletion Modules/_cursesmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4959,7 +4959,11 @@ Return a logical OR of all video attributes supported by the terminal.
static PyObject *
_curses_termattrs_impl(PyObject *module)
/*[clinic end generated code: output=b06f437fce1b6fc4 input=0559882a04f84d1d]*/
NoArgReturnIntFunctionBody(termattrs)
{
PyCursesStatefulInitialised(module);

return PyLong_FromUnsignedLong((unsigned long)(chtype)termattrs());
}

/*[clinic input]
@permit_long_summary
Expand Down
Loading