Skip to content

gh-154916: Fix data race on a shared types.GenericAlias iterator in ga_iter_reduce under free-threading #155476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ByteFlowing1337 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

gh-154916: Fix data race on a shared types.GenericAlias iterator in ga_iter_reduce under free-threading #155476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-08-10-16-57-53.gh-issue-154916.6ozWLF.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix data race when calling :meth:`~object.__reduce__` on a shared :class:`types.GenericAlias` iterator
under the :term:`free-threaded build`.
5 changes: 3 additions & 2 deletions Objects/genericaliasobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,13 +992,14 @@ ga_iter_reduce(PyObject *self, PyObject *Py_UNUSED(ignored))
{
PyObject *iter = _PyEval_GetBuiltin(&_Py_ID(iter));
gaiterobject *gi = (gaiterobject *)self;
PyObject *obj = FT_ATOMIC_LOAD_PTR(gi->obj);

/* _PyEval_GetBuiltin can invoke arbitrary code,
* call must be before access of iterator pointers.
* see issue #101765 */

if (gi->obj)
return Py_BuildValue("N(O)", iter, gi->obj);
if (obj)
return Py_BuildValue("N(O)", iter, obj);
else
return Py_BuildValue("N(())", iter);
}
Expand Down
Loading