Skip to content

[3.15] gh-62917: Add tests for urllib.request.urlcleanup() (GH-155446) #155465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miss-islington wants to merge 1 commit into
base: 3.15
Choose a base branch
from
+55 −0
Open

[3.15] gh-62917: Add tests for urllib.request.urlcleanup() (GH-155446) #155465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions Lib/test/test_urllib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,61 @@ def test_short_content_raises_ContentTooShortError_without_reporthook(self):
self.unfakehttp()


class urlcleanup_Tests(unittest.TestCase, FakeHTTPMixin):
"""Test urllib.request.urlcleanup()"""

def setUp(self):
self.addCleanup(urllib.request.urlcleanup)

def urlretrieve(self):
self.fakehttp(b'HTTP/1.1 200 OK\r\n\r\ndata')
try:
filename, headers = urllib.request.urlretrieve(
support.TEST_HTTP_URL)
finally:
self.unfakehttp()
self.addCleanup(os_helper.unlink, filename)
return filename

def fake_urlopen(self, data):
self.fakehttp(b'HTTP/1.1 200 OK\r\n\r\n' + data)
try:
with urllib.request.urlopen(support.TEST_HTTP_URL) as fp:
return fp.read()
finally:
self.unfakehttp()

def test_temporary_files(self):
filename = self.urlretrieve()
self.assertTrue(os.path.exists(filename))

urllib.request.urlcleanup()
self.assertFalse(os.path.exists(filename))

# A file created after the cleanup is not deleted.
os_helper.create_empty_file(filename)
urllib.request.urlcleanup()
self.assertTrue(os.path.exists(filename))

def test_opener(self):
# The implicitly created opener supports http.
self.assertEqual(self.fake_urlopen(b'first'), b'first')

# An installed opener replaces it and supports only its handlers.
opener = urllib.request.OpenerDirector()
opener.add_handler(urllib.request.DataHandler())
opener.add_handler(urllib.request.UnknownHandler())
urllib.request.install_opener(opener)
with urllib.request.urlopen('data:,hello') as fp:
self.assertEqual(fp.read(), b'hello')
with self.assertRaises(urllib.error.URLError):
self.fake_urlopen(b'')

# urlcleanup() resets the opener.
urllib.request.urlcleanup()
self.assertEqual(self.fake_urlopen(b'second'), b'second')


class QuotingTests(unittest.TestCase):
r"""Tests for urllib.quote() and urllib.quote_plus()

Expand Down
Loading