gh-102184: Test os.sync() only if the "walltime" resource is enabled - #155448
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-102184: Test os.sync() only if the "walltime" resource is enabled#155448serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
…abled Calling sync() flushes all filesystem buffers and can block for a long time, so it should not run in the default test suite. Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync()was called unconditionally intestNoArgFunctions(), so a plainmake testflushed every filesystem buffer on the machine. It is now a separate test gated onwalltime, the resource for tests that are slow by the clock --largefile, as proposed in #102185, andcpudescribe the wrong cost.