Skip to content

[3.10] gh-146581: Fix vulnerability in shutil.unpack_archive() for ZIP files on Windows (GH-146591) (GH-149071) - #155440

Open
miss-islington wants to merge 1 commit into
python:3.10from
miss-islington:backport-7ef7dd0-3.10
Open

[3.10] gh-146581: Fix vulnerability in shutil.unpack_archive() for ZIP files on Windows (GH-146591) (GH-149071)#155440
miss-islington wants to merge 1 commit into
python:3.10from
miss-islington:backport-7ef7dd0-3.10

Conversation

@miss-islington

Copy link
Copy Markdown
Contributor

gh-146581: Fix vulnerability in shutil.unpack_archive() for ZIP files on Windows (GH-146591)

Use ZipFile.extractall() to sanitize file names and extract files.

Files with invalid names (e.g. absolute paths) are now skipped.

Files containing ".." in the name are no longer skipped.
(cherry picked from commit 7ef7dd0)

Co-authored-by: Serhiy Storchaka storchaka@gmail.com
(cherry picked from commit fc829e8)

…for ZIP files on Windows (pythonGH-146591) (pythonGH-149071)

pythongh-146581: Fix vulnerability in shutil.unpack_archive() for ZIP files on Windows (pythonGH-146591)

Use ZipFile.extractall() to sanitize file names and extract files.

Files with invalid names (e.g. absolute paths) are now skipped.

Files containing ".." in the name are no longer skipped.
(cherry picked from commit 7ef7dd0)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit fc829e8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants