gh-89132: Fix subclassing of annotated types - #155360
Open
serhiy-storchaka wants to merge 1 commit into
Open
Conversation
__mro_entries__() of an annotated type now delegates to __mro_entries__() of the annotated type itself if it is not a class, e.g. a generic alias. Subclassing Annotated[X, ...] is now the same as subclassing X.
serhiy-storchaka
requested review from
AlexWaygood and
JelleZijlstra
as code owners
August 7, 2026 19:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subclassing an annotated type only worked if the annotated type was a class:
__mro_entries__()returned the annotated type itself, but it can need a resolution too. It now delegates to__mro_entries__()of the annotated type, so subclassingAnnotated[X, ...]is the same as subclassingX, including the error ifXcannot be subclassed.