gh-155332: Use self.Value instead of bare Value in two threads-only pool tests - #155333
Open
Talen400 wants to merge 1 commit into
Open
gh-155332: Use self.Value instead of bare Value in two threads-only pool tests#155333Talen400 wants to merge 1 commit into
Talen400 wants to merge 1 commit into
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a NameError when ctypes/sharedctypes are unavailable (gh-155332):
these two tests used the module-level
Valuefrom the guarded sharedctypesimport, with no HAS_SHAREDCTYPES skip guard.
The tests are threads-only, so self.Value resolves to
multiprocessing.dummy.Value and no longer depends on sharedctypes; this
also matches how the rest of the suite creates shared values. When ctypes
is available both forms are equivalent (value initialized to zero).
First contribution to CPython - happy to adjust to the project process