gh-123011: Fix warn_explicit() with the globals of the __main__ module - #155318
Open
serhiy-storchaka wants to merge 2 commits into
Open
gh-123011: Fix warn_explicit() with the globals of the __main__ module#155318serhiy-storchaka wants to merge 2 commits into
serhiy-storchaka wants to merge 2 commits into
Conversation
… module The __main__ module executed as a script or a command has __spec__ set to None, so warn_explicit(module_globals=globals()) emitted a spurious DeprecationWarning. It also raised ImportError when the loader was unable to provide the source of the module: when the module was executed with -m (the loader can only handle its own module name) or as a command (the built-in importer has no source).
serhiy-storchaka
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
August 7, 2026 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warnings.warn_explicit(module_globals=globals())failed in the__main__module:DeprecationWarning: Module globals is missing a __spec__.loader, because__main__has__spec__set toNone;-mit raisedImportError: loader for spam cannot handle __main__, because__name__was used instead of__spec__.name;ImportError: '__main__' is not a built-in module, because the built-in importer has no source.The source line is now optional: an
ImportErrorfrom the loader is no longer propagated.The pure Python implementation, which uses
linecache, was not affected.