Skip to content

bpo-30076: Rename the BUILD_{TUPLE,MAP}_UNPACK_WITH_CALL opcodes#15513

Closed
ZackerySpytz wants to merge 2 commits into
python:mainfrom
ZackerySpytz:bpo-30076-rename-opcodes
Closed

bpo-30076: Rename the BUILD_{TUPLE,MAP}_UNPACK_WITH_CALL opcodes#15513
ZackerySpytz wants to merge 2 commits into
python:mainfrom
ZackerySpytz:bpo-30076-rename-opcodes

Conversation

@ZackerySpytz
Copy link
Copy Markdown
Contributor

@ZackerySpytz ZackerySpytz commented Aug 26, 2019 •
edited by bedevere-bot
Loading

serhiy-storchaka
serhiy-storchaka reviewed Aug 26, 2019
View reviewed changes
Comment thread Lib/importlib/_bootstrap_external.py Outdated
Comment thread Lib/test/test_dis.py Outdated
ncoghlan
ncoghlan requested changes Sep 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general update here looks good, but I think I made a mistake in my naming suggestion back in 2017 (short version: I now think the new opcodes should be BUILD_ARG_* rather than BUILD_VAR_*, see the BPO issue for the details).

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 3, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella
Copy link
Copy Markdown
Contributor

csabella commented Jan 16, 2020

@ZackerySpytz, please address the code review. Thanks!

@serhiy-storchaka
Copy link
Copy Markdown
Member

serhiy-storchaka commented Oct 20, 2021

Out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan requested changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz @bedevere-bot @csabella @serhiy-storchaka @ncoghlan @the-knights-who-say-ni