Skip to content

gh-154948: Fix test_zipfile failure when SOURCE_DATE_EPOCH is set - #155001

Merged
StanFromIreland merged 2 commits into
python:mainfrom
StanFromIreland:SOURCE_DATE_EPOCH
Aug 7, 2026
Merged

gh-154948: Fix test_zipfile failure when SOURCE_DATE_EPOCH is set#155001
StanFromIreland merged 2 commits into
python:mainfrom
StanFromIreland:SOURCE_DATE_EPOCH

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Jul 31, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Additionally, move the SOURCE_DATE_EPOCH test helpers from test_py_compile to test.support.os_helper, and refactor a little in test_zipfile and test_random to use them instead of duplicate helpers (they were already used by test_importlib and test_compileall).

@StanFromIreland
Fix test_zipfile failure when SOURCE_DATE_EPOCH is set
0432647 
Additionally, move the `SOURCE_DATE_EPOCH` test helpers from `test_py_compile` to `test.support.os_helper`.
@StanFromIreland StanFromIreland added the tests Tests in the Lib/test dir label Jul 31, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 31, 2026
Open
@StanFromIreland

StanFromIreland commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

CC @vstinner, as you added them a little while ago in #9607.

@read-the-docs-community

read-the-docs-community Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33960581 | 📁 Comparing f189a89 against main (a646c99)

  🔍 Preview build  

18 files changed · ± 18 modified

± Modified

vstinner
vstinner reviewed Aug 7, 2026
View reviewed changes
Comment thread Lib/test/test_zipfile/test_core.py
vstinner
vstinner approved these changes Aug 7, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanFromIreland
StanFromIreland merged commit 82905dd into python:main Aug 7, 2026
54 checks passed
@StanFromIreland
StanFromIreland deleted the SOURCE_DATE_EPOCH branch August 7, 2026 14:21
@StanFromIreland StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Aug 7, 2026
@miss-islington-app

miss-islington-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 82905dd165f198f1b18625ae0f0ede9367df75a4 3.14

@miss-islington-app

miss-islington-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 82905dd165f198f1b18625ae0f0ede9367df75a4 3.13

@miss-islington-app

miss-islington-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 82905dd165f198f1b18625ae0f0ede9367df75a4 3.15

@bedevere-app

bedevere-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

GH-155347 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

@StanFromIreland StanFromIreland

Labels

needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @vstinner