bpo-34679: Add conditional to BaseProactorEventLoop init#15477
Closed
aeros wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Since this PR is primarily a small internal change to the initialization for |
Contributor
Author
|
Normally I would wait a bit before sending out notifications, but I'll do so now since this issue is a release blocker for 3.8.0b4 (which is scheduled for release on 8/26/19). /cc @python/asyncio |
Contributor
Author
|
Since Andrew Svetlov submitted a similar PR (#15492) soon afterwards but added tests, I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a conditional to BaseProactorEventLoop.__init__() to only call set_wakeup_fd() if the current thread is the main thread. Fixes asyncio Windows (this error only occurs on Windows) ValueError (see bpo issue comments).
https://bugs.python.org/issue34679