gh-130821: Improve error messages for magic methods returning wrong type#154606
Closed
prabhleen-kaurr wants to merge 1 commit into
Closed
gh-130821: Improve error messages for magic methods returning wrong type#154606prabhleen-kaurr wants to merge 1 commit into
prabhleen-kaurr wants to merge 1 commit into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
Member
|
This is a dupliocate of #144827. Don't create a PR when one already exists, or at leashttps://github.com/python/cpython/pull/144827t ask the author of the original PR if they intend to continue their work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes remaining inconsistent error messages for magic methods that
return the wrong type, as part of issue #130821.
Changes made to use the consistent
%T.__method__() must return ..., not %Tformat established in previous PRs (#130835, #144737):
Objects/typeobject.c: Fixed__hash__,__init__,__getnewargs_ex__,and
__getnewargs__error messagesPython/bytecodes.c: Fixed__init__error message in EXIT_INIT_CHECKThis follows the pattern established by the merged PRs for this issue.