Skip to content

GH-153809: Untrack TaskObj from GC before calling unregister_task #154563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sergey-miryanov wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −2
Draft

GH-153809: Untrack TaskObj from GC before calling unregister_task #154563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Modules/_asynciomodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2966,13 +2966,12 @@ TaskObj_dealloc(PyObject *self)
if (PyObject_CallFinalizerFromDealloc(self) < 0) {
return; // resurrected
}
PyObject_GC_UnTrack(self);
// unregister the task after finalization so that
// if the task gets resurrected, it remains registered
unregister_task((TaskObj *)self);

PyTypeObject *tp = Py_TYPE(self);
PyObject_GC_UnTrack(self);

PyObject_ClearWeakRefs(self);

(void)TaskObj_clear(self);
Expand Down
Loading