gh-154551: Fix ctypes.util.find_library() in non-UTF-8 locales#154552
Merged
serhiy-storchaka merged 1 commit intoJul 23, 2026
Conversation
_findLib_ld() failed to decode the localized "ld" stderr in the locale encoding. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
enabled auto-merge (squash)
July 23, 2026 17:18
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-154555 is a backport of this pull request to the 3.15 branch. |
|
GH-154556 is a backport of this pull request to the 3.14 branch. |
|
GH-154557 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_findLib_ld()ranldwithuniversal_newlines=True, socommunicate()decoded its output in the locale encoding and failed on a localized diagnostic on stderr. The exception was swallowed, sofind_library()returnedNone. The stderr is discarded and the stdout is already decoded withos.fsdecode(), so the output is now read as bytes.