Skip to content

gh-154546: Validate cookie key before applying in BaseCookie.load() #154547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tonghuaroot wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

gh-154546: Validate cookie key before applying in BaseCookie.load() #154547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/http/cookies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,8 @@ def __parse_string(self, str, patt=_CookiePattern):
else:
parsed_items.append((TYPE_ATTRIBUTE, key, _unquote(value)))
elif value is not None:
if not _is_legal_key(key):
raise CookieError('Illegal key %r' % (key,))
parsed_items.append((TYPE_KEYVALUE, key, self.value_decode(value)))
morsel_seen = True
else:
Expand Down
6 changes: 6 additions & 0 deletions Lib/test/test_http_cookies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,12 @@ def test_illegal_chars(self):
with self.assertRaises(cookies.CookieError):
C.load(rawdata)

def test_illegal_key_no_partial_state(self):
C = cookies.SimpleCookie()
with self.assertRaises(cookies.CookieError):
C.load("a=1; b,c=2; d=3")
self.assertEqual(len(C), 0)

def test_comment_quoting(self):
c = cookies.SimpleCookie()
c['foo'] = '\N{COPYRIGHT SIGN}'
Expand Down
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Library/2026-07-18-12-00-00.gh-issue-154546.CkPrt5.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Validate cookie key characters during parsing in
:meth:`http.cookies.BaseCookie.load` so that an illegal key raises
:exc:`~http.cookies.CookieError` before any cookies are applied. Patch by
tonghuaroot.
Loading