Skip to content

gh-135683: Honor raiseExceptions when opening the file fails in FileHandler #154542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serhiy-storchaka wants to merge 1 commit into
base: main
Choose a base branch
from
+48 −3
Open

gh-135683: Honor raiseExceptions when opening the file fails in FileHandler #154542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Lib/logging/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,7 +1263,12 @@ def emit(self, record):
"""
if self.stream is None:
if self.mode != 'w' or not self._closed:
self.stream = self._open()
# Report an error while opening the file, like emit errors.
try:
self.stream = self._open()
except Exception:
self.handleError(record)
return
if self.stream:
StreamHandler.emit(self, record)

Expand Down
9 changes: 7 additions & 2 deletions Lib/logging/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,8 +563,13 @@ def emit(self, record):
If underlying file has changed, reopen the file before emitting the
record to it.
"""
self.reopenIfNeeded()
logging.FileHandler.emit(self, record)
# Report an error while reopening the file, like emit errors.
try:
self.reopenIfNeeded()
except Exception:
self.handleError(record)
else:
logging.FileHandler.emit(self, record)


class SocketHandler(logging.Handler):
Expand Down
32 changes: 32 additions & 0 deletions Lib/test/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6416,6 +6416,38 @@ def test_emit_after_closing_in_write_mode(self):
with open(self.fn) as fp:
self.assertEqual(fp.read().strip(), '1')

def test_emit_open_error(self):
# gh-135683: an error while opening the file in emit() respects
# raiseExceptions, like an error during the actual write.
d = tempfile.mkdtemp()
self.addCleanup(os_helper.rmtree, d)
r = logging.makeLogRecord({})
old_raise = logging.raiseExceptions
self.addCleanup(setattr, logging, 'raiseExceptions', old_raise)

# FileHandler with delay: the failing open happens in emit().
fh = logging.FileHandler(os.path.join(d, 'missing', 'a.log'),
encoding='utf-8', delay=True)
self.addCleanup(fh.close)
# WatchedFileHandler: reopenIfNeeded() fails after the dir is removed.
subdir = os.path.join(d, 'sub')
os.mkdir(subdir)
wfh = logging.handlers.WatchedFileHandler(
os.path.join(subdir, 'b.log'), encoding='utf-8')
self.addCleanup(wfh.close)
os_helper.rmtree(subdir)

for h in (fh, wfh):
logging.raiseExceptions = True
with support.captured_stderr() as stderr:
h.handle(r)
self.assertIn('\nFileNotFoundError:', stderr.getvalue())

logging.raiseExceptions = False
with support.captured_stderr() as stderr:
h.handle(r)
self.assertEqual('', stderr.getvalue())

class RotatingFileHandlerTest(BaseFileTest):
def test_should_not_rollover(self):
# If file is empty rollover never occurs
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-07-23-14-13-39.gh-issue-135683.droBu7.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
:class:`logging.FileHandler` and :class:`logging.handlers.WatchedFileHandler`
now honor :data:`logging.raiseExceptions` for errors that occur while opening
the file, like for other errors during logging.
Loading