gh-154525: Fix curses getcchar() failure on ncurses older than 6.3#154526
Open
serhiy-storchaka wants to merge 2 commits into
Open
gh-154525: Fix curses getcchar() failure on ncurses older than 6.3#154526serhiy-storchaka wants to merge 2 commits into
serhiy-storchaka wants to merge 2 commits into
Conversation
getcchar() rejected a non-NULL opts argument before ncurses 6.3, so read the color pair through the short slot instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
_NCURSES_GETCCHAR_EXTENDED_PAIR was referenced in only one place; move the version condition and its comment to that call site. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getcchar()rejected a non-NULLoptsargument before ncurses 6.3 (patch 20210116).curses_getcchar()passes the color pair throughopts, so on ncurses 6.1 and 6.2 every wide-character cell read failed withgetcchar() returned ERR, breakingcomplexchar,in_wch(),getbkgrnd(), and (via gh-153395) headlesstest_curses.Read the pair through the short slot on older ncurses. main-only -- the
optspath andcomplexcharare 3.16-only.