gh-99999: Refactor hsv_to_rgb in colorsys to remove dead code branch#154501
gh-99999: Refactor hsv_to_rgb in colorsys to remove dead code branch#154501StepashkaHollow wants to merge 6 commits into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
@bedevere check |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
|
@bedevere check |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
The
if i == 5:check inhsv_to_rgbis redundant becausei = i % 6guarantees thatiwill be between 0 and 5. If it's not 0, 1, 2, 3, or 4, it must be 5.Replacing it with
else:simplifies the logic and achieves 100% test coverage forcolorsys.py(removing the uncovered164->exitbranch).