Skip to content

gh-154272: Skip more forkserver tests if the start method is unavailable#154499

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:forkserver-skip-followup
Jul 22, 2026
Merged

gh-154272: Skip more forkserver tests if the start method is unavailable#154499
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:forkserver-skip-followup

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 22, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

test_forkserver and test_process_forkserver_pickle were guarded by platform name (Cygwin and Windows) rather than by whether the forkserver start method exists, so they still failed on illumos.

Verified there, where get_all_start_methods() returns ['spawn', 'fork']: both now skip, and the full suite goes from 5 failing files to 3.

@serhiy-storchaka @claude
pythongh-154272: Skip more forkserver tests if the start method is un…
3c2f06f 
…available

Two tests were still not skipped: they were only guarded against Cygwin
and Windows.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jul 22, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 22, 2026
Closed
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) July 22, 2026 17:55
@serhiy-storchaka
serhiy-storchaka merged commit a2a8466 into python:main Jul 22, 2026
55 checks passed
This was referenced Jul 22, 2026
Merged
Merged
Merged
@bedevere-app

bedevere-app Bot commented Jul 22, 2026

Copy link
Copy Markdown

GH-154506 is a backport of this pull request to the 3.14 branch.

@bedevere-app

bedevere-app Bot commented Jul 22, 2026

Copy link
Copy Markdown

GH-154507 is a backport of this pull request to the 3.13 branch.

@bedevere-app

bedevere-app Bot commented Jul 22, 2026

Copy link
Copy Markdown

GH-154505 is a backport of this pull request to the 3.15 branch.

serhiy-storchaka added a commit that referenced this pull request Jul 22, 2026
@serhiy-storchaka @claude
[3.13] gh-154272: Skip more forkserver tests if the start method is u…
b51729a 
…navailable (GH-154499) (GH-154507)

Two tests were still not skipped: they were only guarded against Cygwin
and Windows.

(cherry picked from commit a2a8466)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka added a commit that referenced this pull request Jul 22, 2026
@serhiy-storchaka @claude
[3.15] gh-154272: Skip more forkserver tests if the start method is u…
6bc3e6c 
…navailable (GH-154499) (GH-154505)

Two tests were still not skipped: they were only guarded against Cygwin
and Windows.

(cherry picked from commit a2a8466)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka added a commit that referenced this pull request Jul 22, 2026
@serhiy-storchaka @claude
[3.14] gh-154272: Skip more forkserver tests if the start method is u…
9585cc3 
…navailable (GH-154499) (GH-154506)

Two tests were still not skipped: they were only guarded against Cygwin
and Windows.

(cherry picked from commit a2a8466)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
@bedevere-bot

bedevere-bot commented Jul 22, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-wasi 3.15 (tier-2) has failed when building commit 6bc3e6c.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/2062/builds/481) and take a look at the build logs.
  4. Check if the failure is related to this commit (6bc3e6c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/2062/builds/481

Failed tests:

  • test_zipfile

Failed subtests:

  • test_write_filtered_python_package - test.test_zipfile.test_core.PyZipFileTests.test_write_filtered_python_package

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Lib/test/test_zipfile/test_core.py", line 1516, in test_write_filtered_python_package
    zipfp.writepy(packagedir)
    ~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/Lib/zipfile/__init__.py", line 2268, in writepy
    self.writestr(arcname, bytecode)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "/Lib/zipfile/__init__.py", line 2038, in writestr
    with self.open(zinfo, mode='w') as dest:
         ~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/Lib/zipfile/__init__.py", line 1380, in close
    self._fileobj.seek(self._zinfo.header_offset)
    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 51] No space left on device


Traceback (most recent call last):
  File "/Lib/test/test_zipfile/test_core.py", line 1511, in test_write_filtered_python_package
    with TemporaryFile() as t, zipfile.PyZipFile(t, "w") as zipfp:
                               ~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/Lib/zipfile/__init__.py", line 1523, in __exit__
    self.close()
    ~~~~~~~~~~^^
  File "/Lib/zipfile/__init__.py", line 2095, in close
    self.fp.seek(self.start_dir)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^
OSError: [Errno 51] No space left on device


Traceback (most recent call last):
  File "/Lib/test/test_zipfile/test_core.py", line 1511, in test_write_filtered_python_package
    with TemporaryFile() as t, zipfile.PyZipFile(t, "w") as zipfp:
         ~~~~~~~~~~~~~^^
OSError: [Errno 51] No space left on device

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-multiprocessing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @bedevere-bot