Skip to content

bpo-37915: Fix comparison between tzinfo objects and timezone objects#15390

Merged
miss-islington merged 5 commits into
python:masterfrom
pablogsal:bpo-37915
Aug 22, 2019
Merged

bpo-37915: Fix comparison between tzinfo objects and timezone objects#15390
miss-islington merged 5 commits into
python:masterfrom
pablogsal:bpo-37915

Conversation

@pablogsal
Copy link
Copy Markdown
Member

@pablogsal pablogsal commented Aug 22, 2019 •
edited by miss-islington
Loading

@pablogsal pablogsal requested a review from pganssle August 22, 2019 15:12
@pablogsal pablogsal requested a review from abalkin as a code owner August 22, 2019 15:12
pganssle
pganssle requested changes Aug 22, 2019
View reviewed changes
Comment thread Lib/test/datetimetester.py
Comment thread Misc/NEWS.d/next/Library/2019-08-22-16-13-27.bpo-37915.xyoZI5.rst Outdated
Comment thread Modules/_datetimemodule.c
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 22, 2019

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@pablogsal @pganssle
Update Misc/NEWS.d/next/Library/2019-08-22-16-13-27.bpo-37915.xyoZI5.rst
0ea14fc 
Co-Authored-By: Paul Ganssle <pganssle@users.noreply.github.com>
@pablogsal
Copy link
Copy Markdown
Member Author

pablogsal commented Aug 22, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 22, 2019

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

@tirkarthi
Copy link
Copy Markdown
Member

tirkarthi commented Aug 22, 2019

3.7 also has this change with 6ed20e5 and would require a backport. Thanks Pablo for the fix.

@pablogsal pablogsal requested a review from pganssle August 22, 2019 17:37
@miss-islington miss-islington merged commit 4be11c0 into python:master Aug 22, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 22, 2019

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 22, 2019

GH-15399 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 22, 2019

Sorry, @pablogsal, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4be11c009abe88175fa164b45e4838e7267dfa97 3.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2019
@pablogsal @miss-islington
bpo-37915: Fix comparison between tzinfo objects and timezone objects (…
86e857a 
…pythonGH-15390)

https://bugs.python.org/issue37915

Automerge-Triggered-By: @pablogsal
(cherry picked from commit 4be11c0)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@miss-islington miss-islington self-assigned this Aug 22, 2019
miss-islington added a commit that referenced this pull request Aug 23, 2019
@miss-islington @pablogsal
bpo-37915: Fix comparison between tzinfo objects and timezone objects (…
5c77730 
…GH-15390)

https://bugs.python.org/issue37915

Automerge-Triggered-By: @pablogsal
(cherry picked from commit 4be11c0)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal pablogsal deleted the bpo-37915 branch August 23, 2019 09:51
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 23, 2019

GH-15417 is a backport of this pull request to the 3.7 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 23, 2019
@pablogsal
[3.7] bpo-37915: Fix comparison between tzinfo objects and timezone o…
c5c873f 
…bjects (pythonGH-15390)

https://bugs.python.org/issue37915

Automerge-Triggered-By: @pablogsal.
(cherry picked from commit 4be11c0)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Aug 23, 2019
@pablogsal
[3.7] bpo-37915: Fix comparison between tzinfo objects and timezone o…
1b1796d 
…bjects (GH-15390) (GH-15417)

https://bugs.python.org/issue37915

Automerge-Triggered-By: @pablogsal.
(cherry picked from commit 4be11c0)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@TomAugspurger TomAugspurger mentioned this pull request Aug 23, 2019
Merged
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@pablogsal @lisroach
bpo-37915: Fix comparison between tzinfo objects and timezone objects (…
5966fd6 
…pythonGH-15390)

https://bugs.python.org/issue37915



Automerge-Triggered-By: @pablogsal
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@pablogsal @DinoV
bpo-37915: Fix comparison between tzinfo objects and timezone objects (…
5928f09 
…pythonGH-15390)

https://bugs.python.org/issue37915



Automerge-Triggered-By: @pablogsal
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@pablogsal @websurfer5
bpo-37915: Fix comparison between tzinfo objects and timezone objects (…
6bb543d 
…pythonGH-15390)

https://bugs.python.org/issue37915



Automerge-Triggered-By: @pablogsal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@abalkin abalkin Awaiting requested review from abalkin

@pganssle pganssle Awaiting requested review from pganssle

Assignees

@miss-islington miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pablogsal @bedevere-bot @tirkarthi @miss-islington @pganssle @serhiy-storchaka @the-knights-who-say-ni