gh-153689: Fix integer overflows in PyObject_CopyData#153690
Open
imabd645 wants to merge 1 commit into
Open
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
c5f47dd to
07bd45d
Compare
PyObject_CopyData
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two integer overflow vulnerabilities explicitly marked by developers with
XXX(nnorwitz)inObjects/abstract.c, specifically withinPyObject_CopyDatawhen handling the Buffer API.If a multi-dimensional buffer object is provided with artificially large dimensions or shape array entries, it could wrap around integer variables leading to heap memory corruption or incomplete copy logic.
Changes made
view_src.ndimis withinPyBUF_MAX_NDIMbefore attempting memory allocation for indices, guaranteeingsizeof(Py_ssize_t) * ndimwill never integer-overflow.elements > PY_SSIZE_T_MAX / view_src.shape[k]) that returns a standardBufferErrorinstead of overflowing thePy_ssize_tcounter.The appropriate blurb entry for
Misc/NEWS.dhas been generated and included in this commit.