gh-153625: rewrite with original filename in append mode for zipfile#153626
Open
danny0838 wants to merge 7 commits into
Open
gh-153625: rewrite with original filename in append mode for zipfile#153626danny0838 wants to merge 7 commits into
danny0838 wants to merge 7 commits into
Conversation
Make the issue more obvious that it can happen when the ZIP archive is "normally" processed on different platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue that auto-sanitized filename corrupts a ZIP archive when rewritten to the central directory in append mode.
ZipInfo.orig_filenameis now only set when read from an archive; otherwise it fallbacks toZipInfo.filename. When writing,ZipInfo.orig_filenamerather thanZipInfo.filenameis used to ensure that the identical original filename is written back.A setter of
ZipInfo.orig_filenameis provided for backword compatibility, although it is not mean to be modified. (Actually, mostZipInfoattributes should not be modified. Though I leave it to future when a breaking change is well-prepared.)zipfileappend corrupts a file due to auto filename sanitization #153625