gh-153513: Remove obsolete Tk version guards in tkinter tests#153615
Merged
serhiy-storchaka merged 1 commit intoJul 12, 2026
Merged
Conversation
Since pythongh-153513, _tkinter returns int, float and pixel objects for the corresponding Tcl object types on all Tk versions. The tests for the Text "tabs" and ttk "padding" options therefore no longer need to expect string tuples on Tk older than 8.6.14. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since gh-153513,
_tkinterreturnsint,floatand pixel objects for the corresponding Tcl object types on all Tk versions.The tests for the Text
tabsand ttkpaddingoptions therefore no longer need to expect string tuples on Tk older than 8.6.14. This makes them fail on real Tk 8.6.13 (as seen on the buildbots), while passing on the newer Tk of most development machines.Verified by relinking
_tkinteragainst Tk 8.6.8, 8.6.9, 8.6.13, 8.6.14, 8.6.15, 8.6.18 and 9.1b1.Fixes #153599.