gh-153354: Fix bool conversion in generated __annotate__#153360
Open
BHUVANSH855 wants to merge 1 commit into
Open
gh-153354: Fix bool conversion in generated __annotate__#153360BHUVANSH855 wants to merge 1 commit into
BHUVANSH855 wants to merge 1 commit into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
sobolevn
reviewed
Jul 8, 2026
361e81b to
de184ba
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the compiler-generated
__annotate__guard by emittingTO_BOOLafterCOMPARE_OP, allowing the optimizer to generate the bool-convertingCOMPARE_OPbeforePOP_JUMP_IF_FALSE.Previously, the generated bytecode omitted the bool conversion required before
POP_JUMP_IF_FALSE, allowing a non-boolean result from__gt__to reach the jump. On debug builds this triggered an assertion failure, while release builds could exhibit incorrect behavior.Changes
TO_BOOLafter the generatedCOMPARE_OPincodegen_setup_annotations_scope(), allowing the optimizer to fold it into a bool-convertingCOMPARE_OP.__annotate__functions for functions, classes, and modules.Issue
Fixes gh-153354.
Testing
COMPARE_OP (bool(>)), matching normal conditional comparison code generation after optimization.