Skip to content

gh-143750: Compile OpenSSL with TSan for TSan CI#153316

Merged
kumaraditya303 merged 5 commits into
python:mainfrom
kumaraditya303:gh-143750-openssl-tsan
Jul 8, 2026
Merged

gh-143750: Compile OpenSSL with TSan for TSan CI#153316
kumaraditya303 merged 5 commits into
python:mainfrom
kumaraditya303:gh-143750-openssl-tsan

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Jul 8, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This PR supersedes #143752 and builds openssl with tsan for tsan CI to avoid false-positives.

@bedevere-app bedevere-app Bot mentioned this pull request Jul 8, 2026
Open
colesbury and others added 2 commits July 8, 2026 15:37
@colesbury @kumaraditya303
pythongh-143750: Compile OpenSSL with TSan for TSan CI
06b4de4 
- Also fix "Install dependencies" step so that we use the installed Clang.
  We can use clang-20 on both ASan and TSan now.
@kumaraditya303
Revert "Temporarily allow the TSan (free-threading) job to fail (pyth…
c25b785 
…on#152173)"

This reverts commit 4f39efc.
@kumaraditya303 kumaraditya303 force-pushed the gh-143750-openssl-tsan branch from 8936cbc to c25b785 Compare July 8, 2026 10:09
@kumaraditya303 kumaraditya303 mentioned this pull request Jul 8, 2026
Open
@kumaraditya303 kumaraditya303 marked this pull request as ready for review July 8, 2026 11:13
webknjaz
webknjaz reviewed Jul 8, 2026
View reviewed changes

@webknjaz webknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, seems good, but I have a few cosmetic notes.

Comment thread .github/workflows/reusable-san.yml Outdated
Comment thread .github/workflows/reusable-san.yml Outdated
Comment thread .github/workflows/reusable-san.yml
Comment thread .github/workflows/reusable-san.yml Outdated
Comment thread .github/workflows/reusable-san.yml Outdated
Comment thread .github/workflows/reusable-san.yml Outdated
Comment thread .github/workflows/reusable-san.yml
webknjaz
webknjaz reviewed Jul 8, 2026
View reviewed changes
Comment thread .github/workflows/reusable-san.yml
webknjaz
webknjaz approved these changes Jul 8, 2026
View reviewed changes

@webknjaz webknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 merged commit fc19ad7 into python:main Jul 8, 2026
48 checks passed
@kumaraditya303 kumaraditya303 deleted the gh-143750-openssl-tsan branch July 8, 2026 15:15
@kumaraditya303 kumaraditya303 added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 8, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 8, 2026

Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jul 8, 2026

Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

miss-islington-app Bot commented Jul 8, 2026

Copy link
Copy Markdown

Sorry, @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fc19ad7b8b08c43667c9087d89f32f08830544ce 3.14

@miss-islington-app

miss-islington-app Bot commented Jul 8, 2026

Copy link
Copy Markdown

Sorry, @kumaraditya303, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fc19ad7b8b08c43667c9087d89f32f08830544ce 3.15

@bedevere-app

bedevere-app Bot commented Jul 8, 2026

Copy link
Copy Markdown

GH-153353 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 8, 2026
@bedevere-app

bedevere-app Bot commented Jul 8, 2026

Copy link
Copy Markdown

GH-153355 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 8, 2026
kumaraditya303 added a commit that referenced this pull request Jul 8, 2026
@kumaraditya303 @colesbury
[3.15] gh-143750: Compile OpenSSL with TSan for TSan CI (#153316) (#1…
6af15c9 
…53353)

gh-143750: Compile OpenSSL with TSan for TSan CI (#153316)

(cherry picked from commit fc19ad7)

Co-authored-by: Sam Gross <colesbury@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro is a code owner
@JacobCoffee JacobCoffee Awaiting requested review from JacobCoffee JacobCoffee is a code owner

Assignees

@kumaraditya303 kumaraditya303

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kumaraditya303 @webknjaz @colesbury