Skip to content

gh-153309 Add HTTP QUERY method (RFC 10008) to http library#153310

Open
mbeijen wants to merge 6 commits into
python:mainfrom
mbeijen:httplib-query-method-rfc-10008
Open

gh-153309 Add HTTP QUERY method (RFC 10008) to http library#153310
mbeijen wants to merge 6 commits into
python:mainfrom
mbeijen:httplib-query-method-rfc-10008

Conversation

@mbeijen

@mbeijen mbeijen commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

RFC 10008: The HTTP QUERY Method is now a finalized RFC on the Standards track, and the method name has been added to the IANA registry

Add it to http library HTTPMethod enum, too

@read-the-docs-community

read-the-docs-community Bot commented Jul 8, 2026

Copy link
Copy Markdown

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need something like do_QUERY in HTTP client etcs? please also check if we need tests for that.

@mbeijen

mbeijen commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Don't we need something like do_QUERY in HTTP client etcs? please also check if we need tests for that.

We have these do_ methods in server, not in the client. And we do not need to add QUERY there, we have this code

mname = 'do_' + self.command
that automatically parses the method names. We also do not have explicit methods there for do_DELETE and so on.

Comment thread Lib/http/__init__.py Outdated
Co-authored-by: Eduardo Villalpando Mello <eduardo.villalpando.mello@gmail.com>

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not a full review)

@@ -0,0 +1 @@
Add the HTTP QUERY method (RFC 10008) to http.HTTPMethod.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add the HTTP QUERY method (RFC 10008) to http.HTTPMethod.
Add the HTTP QUERY method
(`RFC 10008 <https://www.rfc-editor.org/info/rfc10008/>`_)
to :class:`http.HTTPMethod`.

@picnixz picnixz Jul 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using the rfc role (it can link sections as well)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, even better. TIL

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion @picnixz I added that in 6230654

@picnixz

picnixz commented Jul 8, 2026

Copy link
Copy Markdown
Member

(I will do a review tomorrow while I am commuting)

@picnixz picnixz self-requested a review July 8, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants