Skip to content

bpo-37884: Optimize Fraction() and statistics.mean() #15329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
serhiy-storchaka wants to merge 5 commits into from
Closed

bpo-37884: Optimize Fraction() and statistics.mean() #15329

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
482b1f9
bpo-37822: Add math.as_integer_ratio().
serhiy-storchaka Aug 11, 2019
a587d7d
Better TypeError message.
serhiy-storchaka Aug 11, 2019
55232b3
Merge branch 'master' into math-as_integer_ratio
serhiy-storchaka Aug 19, 2019
e658d19
Make it a private helper math._as_integer_ratio().
serhiy-storchaka Aug 19, 2019
86f9f20
Optimize.
serhiy-storchaka Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Better TypeError message.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Aug 11, 2019
commit a587d7d890f137f196ea2de650d324889d5eac5d
4 changes: 2 additions & 2 deletions Lib/fractions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ def __new__(cls, numerator=0, denominator=None, *, _normalize=True):
self._numerator, self._denominator = math.as_integer_ratio(numerator)
return self
except TypeError:
raise TypeError("argument should be a string "
"or a Rational instance")
raise TypeError("argument should be a string or a number, "
Copy link
Copy Markdown
Contributor

@aeros aeros Aug 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the name of the encompassing type is "numeric" rather than "number", can we adjust the error message?

Suggested change
raise TypeError("argument should be a string or a number, "
raise TypeError("argument type should be str or numeric, "

Source: https://docs.python.org/3.9/library/stdtypes.html#numeric-types-int-float-complex

Copy link
Copy Markdown
Member Author

@serhiy-storchaka serhiy-storchaka Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But an instance of a numeric type is a number, is not?

And if use "argument type", it should be "str", not "string".

Copy link
Copy Markdown
Contributor

@aeros aeros Aug 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But an instance of a numeric type is a number, is not?

It is, but I think that it's a bit more useful to users to specify the actual types in this case since it's a TypeError. Also, when searching the docs for "number", the relevant documentation page ("Built-in Types") does not come up as a suggestion, instead they'll likely encounter the page for the "numbers" module (which would not be relevant to the error). When searching for "numeric", more relevant results are found, including "Built-in Types".

And if use "argument type", it should be "str", not "string".

I'll update the suggestion accordingly.

Copy link
Copy Markdown
Member Author

@serhiy-storchaka serhiy-storchaka Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a standard message used in many sites. For example:

>>> float([])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: float() argument must be a string or a number, not 'list'

If you want to change it, please open a separate issue.

Copy link
Copy Markdown
Contributor

@aeros aeros Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to change it, please open a separate issue.

Alright, I'll take a look at what other areas use this error message and consider whether or not it should be addressed. That would definitely go outside of the scope of this PR.

"not %s" % type(numerator).__name__) from None

elif type(numerator) is int is type(denominator):
pass # *very* normal case
Expand Down