Skip to content

gh-153210: Restore accidental array.ArrayType removal#153261

Merged
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-153210-2
Jul 7, 2026
Merged

gh-153210: Restore accidental array.ArrayType removal#153261
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-153210-2

Conversation

@sobolevn

@sobolevn sobolevn commented Jul 7, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Ok, here's what happened:

  1. I got confused that array.ArrayType and array.array is the same thing, it is exported under two different names
  2. There was no test to catch this :(

I added a test case and a comment.
Refs #153238

Backporting to all the same versions as #153238

@sobolevn sobolevn requested a review from nedbat July 7, 2026 12:29
@sobolevn sobolevn added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 7, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 7, 2026
Open
@StanFromIreland StanFromIreland mentioned this pull request Jul 7, 2026
Merged
@sobolevn sobolevn merged commit ac2e14b into python:main Jul 7, 2026
102 of 104 checks passed
@miss-islington-app

miss-islington-app Bot commented Jul 7, 2026

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 7, 2026

Copy link
Copy Markdown

GH-153274 is a backport of this pull request to the 3.15 branch.

@miss-islington-app

miss-islington-app Bot commented Jul 7, 2026

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ac2e14b4e29b2d11a14d289969cfffc298ea75d9 3.13

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 7, 2026
@bedevere-app

bedevere-app Bot commented Jul 7, 2026

Copy link
Copy Markdown

GH-153275 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2026
sobolevn added a commit that referenced this pull request Jul 7, 2026
@miss-islington @sobolevn
[3.14] gh-153210: Restore accidental array.ArrayType removal (GH-15…
f98f943 
…3261) (#153275)

gh-153210: Restore accidental `array.ArrayType` removal (GH-153261)
(cherry picked from commit ac2e14b)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jul 7, 2026
@miss-islington @sobolevn
[3.15] gh-153210: Restore accidental array.ArrayType removal (GH-15…
557e994 
…3261) (#153274)

gh-153210: Restore accidental `array.ArrayType` removal (GH-153261)
(cherry picked from commit ac2e14b)

Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nedbat nedbat Awaiting requested review from nedbat

Assignees

@sobolevn sobolevn

Labels

needs backport to 3.13 bugs and security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sobolevn