gh-148286: Fix UB in ZstdDecompressor.unused_data when a frame is decompressed in one call#153258
Open
StanFromIreland wants to merge 1 commit into
Open
gh-148286: Fix UB in ZstdDecompressor.unused_data when a frame is decompressed in one call#153258StanFromIreland wants to merge 1 commit into
ZstdDecompressor.unused_data when a frame is decompressed in one call#153258StanFromIreland wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce, run
test_zstd.CompressorTestCase.test_compress_flushblockor under UBSan:ZstdDecompressor.unused_datacomputesself->input_buffer + self->in_beginwithout checking thatinput_bufferwas ever allocated, so when a frame is fully consumed in a singledecompress()call it leavesinput_bufferNULL (andin_begin/in_endat their initial state). Reading.unused_dataevaluatesNULL + ..., which is UB. Although the resulting length ofin_end - in_begin == 0means it accidentally returns the correctb''.The other
unused_dataimplementations are not affected due to their design.Also, CC @Rogdham