gh-153200: Fix math.isqrt() for int subclasses with overridden comparison operators#153203
Merged
serhiy-storchaka merged 1 commit intoJul 6, 2026
Merged
Conversation
…comparison operators The final check-and-correct comparison in the arbitrary precision path could call a comparison operator overridden in an int subclass. Compare by value with int's tp_richcompare. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-153223 is a backport of this pull request to the 3.15 branch. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-153225 is a backport of this pull request to the 3.14 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 6, 2026
… comparison operators (GH-153203) (GH-153225) The final check-and-correct comparison in the arbitrary precision path could call a comparison operator overridden in an int subclass. Compare by value with int's tp_richcompare. (cherry picked from commit 3a1b547) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 6, 2026
… comparison operators (GH-153203) (GH-153225) (GH-153226) The final check-and-correct comparison in the arbitrary precision path could call a comparison operator overridden in an int subclass. Compare by value with int's tp_richcompare. (cherry picked from commit 3a1b547) (cherry picked from commit a9a91d0) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 6, 2026
… comparison operators (GH-153203) (GH-153223) The final check-and-correct comparison in the arbitrary precision path could call a comparison operator overridden in an int subclass. Compare by value with int's tp_richcompare. (cherry picked from commit 3a1b547) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final check-and-correct comparison in the arbitrary precision path could call a comparison operator overridden in an int subclass, producing an off-by-one result for arguments not less than 2**64. Compare by value with int's
tp_richcompareinstead (same approach asPyDict_Type.tp_richcompareinObjects/odictobject.c).🤖 Generated with Claude Code