Add tests for syntax error messages that had no test coverage#153192
Merged
serhiy-storchaka merged 1 commit intoJul 6, 2026
Conversation
"illegal target for annotation" and "cannot use dict unpacking here" were not tested at all, and "f-string: expecting '!', or ':', or '}'" was only tested for its t-string variant. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
pablogsal
approved these changes
Jul 6, 2026
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-153196 is a backport of this pull request to the 3.15 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 6, 2026
…H-153192) (GH-153196) Add tests for syntax error messages that had no test coverage (GH-153192) "illegal target for annotation" and "cannot use dict unpacking here" were not tested at all, and "f-string: expecting '!', or ':', or '}'" was only tested for its t-string variant. (cherry picked from commit 836b206) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for three specialized syntax error messages which a coverage audit of the error rules in
Grammar/python.gramfound untested:illegal target for annotation(e.g.1: int) had no tests at all;cannot use dict unpacking here(e.g.(**a)) had no tests at all;f-string: expecting '!', or ':', or '}'(e.g.f'{a=b}') was only tested for its t-string variant.🤖 Generated with Claude Code