gh-153161: Cache the match object in the compiled re pattern#153162
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-153161: Cache the match object in the compiled re pattern#153162serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
A dead match object is kept in the pattern (it retains only its type reference) and resurrected for the next match instead of allocating a new one. Matches of one pattern all have the same size, and the next match is typically created just before the previous one dies. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dead match object is kept in the pattern (retaining only its type reference) and resurrected for the next match instead of allocating a new one. Matches of one pattern all have the same size, and the next match is typically created just before the previous one dies.
Saves 15-18 ns per successful match. No refleaks; the cache slot is accessed with atomic operations and was stress-tested on the free-threaded build.