gh-153141: Fix mutable default argument in _SharedMemoryTracker.__init__#153142
Merged
gpshead merged 1 commit intoJul 5, 2026
Merged
Conversation
Member
|
skip news added - i'm not bothering with a news entry as this is a trivial invisible to users internal cleanup. |
|
Thanks @whyvineet for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-153145 is a backport of this pull request to the 3.15 branch. |
|
GH-153146 is a backport of this pull request to the 3.14 branch. |
|
GH-153147 is a backport of this pull request to the 3.13 branch. |
gpshead
pushed a commit
that referenced
this pull request
Jul 5, 2026
…r.__init__ (GH-153142) (#153146) gh-153141: Fix mutable default argument in _SharedMemoryTracker.__init__ (GH-153142) Fix default argument for segment_names in _SharedMemoryTracker constructor to not use a mutable list. (cherry picked from commit d733b10) Co-authored-by: Vineet Kumar <108144301+whyvineet@users.noreply.github.com>
gpshead
pushed a commit
that referenced
this pull request
Jul 5, 2026
…r.__init__ (GH-153142) (#153147) gh-153141: Fix mutable default argument in _SharedMemoryTracker.__init__ (GH-153142) Fix default argument for segment_names in _SharedMemoryTracker constructor to not use a mutable list. (cherry picked from commit d733b10) Co-authored-by: Vineet Kumar <108144301+whyvineet@users.noreply.github.com>
gpshead
pushed a commit
that referenced
this pull request
Jul 5, 2026
…r.__init__ (GH-153142) (#153145) gh-153141: Fix mutable default argument in _SharedMemoryTracker.__init__ (GH-153142) Fix default argument for segment_names in _SharedMemoryTracker constructor to not use a mutable list. (cherry picked from commit d733b10) Co-authored-by: Vineet Kumar <108144301+whyvineet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the mutable default argument (
segment_names=[]) in_SharedMemoryTracker.__init__withNoneto avoid unintended shared state between instances.Fixes: #153141