gh-152957: Raise ValueError for invalid <date> in plistlib#152958
Open
tonghuaroot wants to merge 1 commit into
Open
gh-152957: Raise ValueError for invalid <date> in plistlib#152958tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
_date_from_string did _dateParser.match(s).groupdict(). On a non-matching value match() returns None (AttributeError); on a partial match (the regex allows year-only and year-month) too few fields reach datetime.datetime(*lst) (TypeError). Both now raise ValueError, matching the sibling <integer> and <real> elements. The binary plist format decodes dates with struct.unpack and is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_date_from_stringinLib/plistlib.pydid_dateParser.match(s).groupdict().On a non-matching
<date>valuematch()returnsNone, so.groupdict()fails with
AttributeError; on a partial match (the regex allows year-only andyear-month) too few fields reach
datetime.datetime(*lst), which fails withTypeError. Both now raiseValueError, matching the sibling<integer>and<real>elements. The binary plist format decodes dates withstruct.unpackand is unaffected.