gh-152954: Add tp_new to sqlite3 Connection and Cursor objects to initialize row_factory and text_factory before python code can access it#152956
Open
stestagg wants to merge 1 commit into
Open
Conversation
… to initialize row_factory and text_factory before python code can access it (causes crash when NULL), also additional defensive checks, because the cost/performance here is tiny and it's safer to check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also additional defensive checks, because the cost/performance here is tiny and it's safer to check
I think the NULL checks in usage may be contentious, I decided to add them because this is the third attempt to plug the possible holes of these attributes becoming NULL, so it seems safer to add these basically free checks in case some other condition also sets these attributes to NULL.