gh-152150: Replacing the old getopt with argparse in base64#152152
Open
ByteFlowing1337 wants to merge 4 commits into
Open
gh-152150: Replacing the old getopt with argparse in base64#152152ByteFlowing1337 wants to merge 4 commits into
getopt with argparse in base64#152152ByteFlowing1337 wants to merge 4 commits into
Conversation
sobolevn
reviewed
Jun 25, 2026
sobolevn
left a comment
Member
There was a problem hiding this comment.
Is there any real reason to do so? Are there any real bugs in using getopt? Will the performance change in a positive way? Will it break something?
Contributor
Author
|
It is similar to what was done in #109164. I don't think it will break anything though, as the behavior remains the same?
|
sobolevn
reviewed
Jun 25, 2026
sobolevn
left a comment
Member
There was a problem hiding this comment.
Please, test new arguments in CLI tests :)
After I would defer this PR to someone else, because I am not a module expert :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getoptwithargparsein CLI #152150