Fix typo in Py_mod_state_traverse docs#152145
Closed
hydrogen-mvm wants to merge 1 commit into
Closed
Conversation
|
All commit authors signed the Contributor License Agreement. |
Documentation build overview
292 files changed ·
|
Member
|
Please open this against See https://devguide.python.org/getting-started/pull-request-lifecycle/#good-prs And make sure your feature branch is created from https://devguide.python.org/getting-started/pull-request-lifecycle/#step-by-step-guide |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Reopening #152144 this time linking to 3.15 branch instead of 3.16.)
I was reading the documentation here for
Py_mod_state_traverse:https://docs.python.org/3.15/c-api/module.html#c.Py_mod_state_traverse
It says at the bottom:
Added in version 3.15: Use [PyModuleDef.m_size] instead to support previous versions.That confused me, since
Py_mod_state_clearsaid to usem_clear, andPy_mod_state_freesaid to usem_free. I think them_sizeforPy_mod_state_traverseis a copypaste error from thePy_mod_state_sizedocs (which also says to usem_size).That said, this API is still very new to me, so please double-check the docs yourselves. This change might also need to be ported to 3.16 docs.
Thanks.